Add offline plugin #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloluis
requested changes
Sep 1, 2017
Collaborator
There was a problem hiding this comment.
Nice work! 👍 We really appreciate your contribution.
-
We are thinking of creating a new seed-branch (
seed/offline) to merge your changes so we keep themasteras simple as possible.
We are trying to avoid having an overwhelming amount of features/packages/configs that aren't essential for starting projects- If you like the idea, let us know and we'll create the
seed/offlinebranch to merge into
- If you like the idea, let us know and we'll create the
-
Please, update the readme with the new seed branch (
Seed Branchessection)
After merging this PR we'll add a Contributors section on the master readme
Thanks for your contribution, and keep up the good work!
Add seed/offline to branches section.
Author
|
Totally agree. I'll send a PR with that update. |
carloluis
reviewed
Sep 2, 2017
Collaborator
carloluis
left a comment
carloluis
left a comment
There was a problem hiding this comment.
Ok. The seed/offline branch is already on the repo.
- I'll change the target branch for merging this PR
Author
|
Awesome, Thanks @carloluis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed on this pull request: