Skip to content

use fetch as a configuration class #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

use fetch as a configuration class #99

merged 1 commit into from
Sep 5, 2018

Conversation

rrivem
Copy link
Contributor

@rrivem rrivem commented Sep 1, 2018

Changes proposed on this pull request:

  • configuration for fetch for easy use and testability of fetch requests

Reviewers

@rrivem rrivem self-assigned this Sep 1, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b10c940 on feature/fetch-chain into b2b192a on develop.

carloluis
carloluis approved these changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@carloluis carloluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rrivem rrivem merged commit da0c690 into develop Sep 5, 2018
@rrivem rrivem deleted the feature/fetch-chain branch September 5, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carloluis carloluis carloluis approved these changes

Assignees

@rrivem rrivem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rrivem @coveralls @carloluis