-
Notifications
You must be signed in to change notification settings - Fork 96
added insertion sort #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you find anything not appropriate, please comment here, and I will look into it and try to get it fixed. |
Utkarsh1504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhijit25Mishra please do these changes which I have suggested you and one more thing please remove the extra files which have been committed
package-lock.json
Your content looks great. Thanks for your hard work.
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
|
OK, I have committed all of your changes, sorry for the typos and markdown error. There were no guidelines for that, so I looked at other files and took a guess whether they were H₂ or H₃. |
lessons/insertion.md
Outdated
| `` | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please remove these.
lessons/insertion.md
Outdated
| `` | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also remove these three lines
Utkarsh1504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhijit25Mishra I think If I will merge your PR package-lock.json file will be removed from the main project so please add this again. If there will be any vulnerability I will fix them.
So please man commit that then I'll merge your request as I was not aware of it.
Ok No Problem man, if you want please update the contribution guideline raise an issue, and then make a PR updating the Contribution guidelines |
Sure i will look into it and see if i can improve something that will help other contibutors! |
|
ok done I have removed that package-lock.json file, its no longer going to affect any other previous files. This PR seems done now. Thank you for ur help. I guess i will move on to other issues XD. |
Utkarsh1504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good🎈🎉✨
|
Thank you for your Patience! |
Fixes #23
Short description of what this resolves:
Added a insertion sort page.
Features added in this pull request:
Checklist
Notes: