Skip to content

Conversation

@Abhijit25Mishra
Copy link
Contributor

Fixes #23

Short description of what this resolves:

Added a insertion sort page.

Features added in this pull request:

  • Introduction to Insertion Sort
  • Complete explanation on Insertion sort
  • Complexity Analysis of Insertion Sort
  • Code for Insertion Sort

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added code examples, test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Abhijit25Mishra
Copy link
Contributor Author

If you find anything not appropriate, please comment here, and I will look into it and try to get it fixed.

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhijit25Mishra please do these changes which I have suggested you and one more thing please remove the extra files which have been committed
package-lock.json

Your content looks great. Thanks for your hard work.

Abhijit25Mishra and others added 9 commits October 1, 2021 22:35
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com>
@Abhijit25Mishra
Copy link
Contributor Author

OK, I have committed all of your changes, sorry for the typos and markdown error. There were no guidelines for that, so I looked at other files and took a guess whether they were H₂ or H₃.
I have also removed the package-lock.json, NPM added or deleted some files due to some updates.
Thank you for all the help.

Comment on lines 116 to 118
``


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please remove these.

Comment on lines 130 to 132
``


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also remove these three lines

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhijit25Mishra I think If I will merge your PR package-lock.json file will be removed from the main project so please add this again. If there will be any vulnerability I will fix them.
So please man commit that then I'll merge your request as I was not aware of it.

@Utkarsh1504
Copy link
Owner

OK, I have committed all of your changes, sorry for the typos and markdown error. There were no guidelines for that, so I looked at other files and took a guess whether they were H₂ or H₃. I have also removed the package-lock.json, NPM added or deleted some files due to some updates. Thank you for all the help.

Ok No Problem man, if you want please update the contribution guideline raise an issue, and then make a PR updating the Contribution guidelines

@Abhijit25Mishra
Copy link
Contributor Author

OK, I have committed all of your changes, sorry for the typos and markdown error. There were no guidelines for that, so I looked at other files and took a guess whether they were H₂ or H₃. I have also removed the package-lock.json, NPM added or deleted some files due to some updates. Thank you for all the help.

Ok No Problem man, if you want please update the contribution guideline raise an issue, and then make a PR updating the Contribution guidelines

Sure i will look into it and see if i can improve something that will help other contibutors!

@Abhijit25Mishra
Copy link
Contributor Author

ok done I have removed that package-lock.json file, its no longer going to affect any other previous files. This PR seems done now. Thank you for ur help. I guess i will move on to other issues XD.

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good🎈🎉✨

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request labels Oct 2, 2021
@Utkarsh1504
Copy link
Owner

Thank you for your Patience!

@Utkarsh1504 Utkarsh1504 merged commit 999d194 into Utkarsh1504:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new lesson: Insertion Sort

2 participants