Skip to content

Conversation

@ananya0504
Copy link
Contributor

Fixes #63

Short description of what this resolves:

improve: Space Complexity #63

What Changes proposed in this pull request:

  • Added more theory
  • Removed the first code snippet and replaced it with a better and easily understandable one
  • Added 1 code snippet for finding space complexity in arrays
  • Improved overall formatting
  • Improved the overall language

Checklist

  • Added description of change
  • Added code examples, the test must pass
  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

  • Improvised on the language of the lesson.
  • Removed certain lines which were difficult to understand for beginners
  • Added necessary formatting


- **Environmental Stack**
-- Sometimes an algorithm(function) may be called inside another algorithm(function). In such a situation, the current variables are pushed onto the system stack, where they wait for further execution and then the call to the inside algorithm(function) is made.\
Ex. If a function A() calls function B() inside it, then all th variables of the function A() will get stored on the system stack temporarily, while the function B() is called and executed inside the funciton A().
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ex. If a function A() calls function B() inside it, then all th variables of the function A() will get stored on the system stack temporarily, while the function B() is called and executed inside the funciton A().
Ex. If a function A() calls function B() inside it, then all the variables of the function A() will get stored on the system stack temporarily, while the function B() is called and executed inside the function A().

please fix this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, you have improved it in a great way, just fix that typo, and I'll merge your PR.
Thank you!

@ananya0504
Copy link
Contributor Author

Okay so I did fixed the typo, and I commit and push it onto my repo

@ananya0504 ananya0504 requested a review from Utkarsh1504 October 3, 2021 19:21
Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Looks good.
Thank you!

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 4, 2021
@Utkarsh1504 Utkarsh1504 merged commit 099efc0 into Utkarsh1504:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve: Space Complexity

2 participants