-
Notifications
You must be signed in to change notification settings - Fork 68
added "Use in Neovim" to readme #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the contribution! At the moment, the instructions sound just a little bit too generic to me. Can you change the tone so that it is clear that this is only one (of possibly many) options to enable the language server? For example, there is a Pull Request trying to add |
Schottkyc137
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To elaborate more on my comment: I think this is more or less one example of how you could integrate vhdl_ls into neovim, correct? If so I'd appreciate it if the text would reflect this.
|
Oh, I didn't know about the Mason PR. Yeah, this would be the preferred way to do it of course. But until its merged, I guess it makes sense to describe a way, how to manually add the LS to Neovim. I know it would've saved me some time a few months back when I started using it and didn't know what I was doing.
At the end of the day they all use the vim.lsp framework. But I will try to make it clear that there is an automatic way upcoming (mason), and that this here is the way to do it manually. If that is ok with you. |
Yea, that sounds good. My only concern is that the, way you described it, it sounds a bit like that's the only way of installing the client for nvim. I'm already happy with changing the title to |
|
I'm happy with the changes now. This is a great addition for anyone trying to use Neovim with |
Yes, all good. Thanks! |
Issue#266