Skip to content

Conversation

@Chris44442
Copy link
Contributor

@Schottkyc137
Copy link
Contributor

Schottkyc137 commented Mar 3, 2024

Thanks for the contribution!

At the moment, the instructions sound just a little bit too generic to me. Can you change the tone so that it is clear that this is only one (of possibly many) options to enable the language server? For example, there is a Pull Request trying to add vhdl_ls to Mason.

Copy link
Contributor

@Schottkyc137 Schottkyc137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To elaborate more on my comment: I think this is more or less one example of how you could integrate vhdl_ls into neovim, correct? If so I'd appreciate it if the text would reflect this.

@Chris44442
Copy link
Contributor Author

Oh, I didn't know about the Mason PR. Yeah, this would be the preferred way to do it of course. But until its merged, I guess it makes sense to describe a way, how to manually add the LS to Neovim. I know it would've saved me some time a few months back when I started using it and didn't know what I was doing.

I think this is more or less one example of how you could integrate vhdl_ls into neovim, correct?

At the end of the day they all use the vim.lsp framework. But I will try to make it clear that there is an automatic way upcoming (mason), and that this here is the way to do it manually. If that is ok with you.

@Schottkyc137
Copy link
Contributor

At the end of the day they all use the vim.lsp framework. But I will try to make it clear that there is an automatic way upcoming (mason), and that this here is the way to do it manually. If that is ok with you.

Yea, that sounds good. My only concern is that the, way you described it, it sounds a bit like that's the only way of installing the client for nvim. I'm already happy with changing the title to Manual Installation for NeoVim (or something in that direction) to signify that there are other methods.

@Schottkyc137
Copy link
Contributor

I'm happy with the changes now. This is a great addition for anyone trying to use Neovim with vhdl_ls. If you're happy too I will merge this.

@Chris44442 Chris44442 requested a review from Schottkyc137 March 3, 2024 16:25
@Chris44442
Copy link
Contributor Author

If you're happy too I will merge this.

Yes, all good. Thanks!

@Schottkyc137 Schottkyc137 merged commit 5ca32e3 into VHDL-LS:master Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants