[RFC] Add option to disable the filepath completer by micbou · Pull Request #1061 · ycm-core/ycmd

micbou · 2018-07-04T14:26:47Z

This PR adds the option filepath_blacklist to allow users to disable the filepath completer from triggering on the / character (and \ on Windows) for a list of filetypes. This option works like the filetype_blacklist option where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key * can be used to blacklist all filetypes.

Contrarily to the filetype_* options, there is no filepath_whitelist counterpart as I don't really see the use case but nothing prevents us from adding it later.

The html, jsx, and xml filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later.

The next step is to give a way to manually trigger filepath completion through a mapping so that even if the filepath_blacklist option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986.

Closes ycm-core/YouCompleteMe#708.
Closes ycm-core/YouCompleteMe#3057.

This change is

bstaletic

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 2 LGTMs obtained

ycmd/completers/general/filename_completer.py, line 86 at r1 (raw file):

    filetypes = request_data[ 'filetypes' ]
    return ( '*' in disabled_filetypes or
             all( x in disabled_filetypes for x in filetypes ) )

This says that in order to disable filepath completer every current filetype needs to be blacklisted.

Wouldn't it be better to use any instead? Think about set filetype=c.doxygen and blacklisting that.

micbou

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 2 LGTMs obtained

ycmd/completers/general/filename_completer.py, line 86 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

This says that in order to disable filepath completer every current filetype needs to be blacklisted.

Wouldn't it be better to use any instead? Think about set filetype=c.doxygen and blacklisting that.

I think you are right. The scenario were a user wants to blacklist the filetype A without blacklisting A.B (or B.A) is unlikely. I'll change it and add a test.

bstaletic

Reviewable status: 0 of 2 LGTMs obtained

ycmd/completers/general/filename_completer.py, line 86 at r1 (raw file):

Previously, micbou wrote…

I think you are right. The scenario were a user wants to blacklist the filetype A without blacklisting A.B (or B.A) is unlikely. I'll change it and add a test.

If someone complains that blacklistin A also balcklists A.B we can add the whitelist, I guess. I wouldn't invest any effort until we get a complaint.

Add an option to disable the filepath completer by filetype.

codecov · 2018-07-04T21:27:18Z

Codecov Report

Merging #1061 into master will decrease coverage by 0.75%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   97.51%   96.75%   -0.76%     
==========================================
  Files          90       90              
  Lines        6950     6623     -327     
==========================================
- Hits         6777     6408     -369     
- Misses        173      215      +42

micbou

Reviewed 3 of 3 files at r2.
Reviewable status: 0 of 2 LGTMs obtained

ycmd/completers/general/filename_completer.py, line 86 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

If someone complains that blacklistin A also balcklists A.B we can add the whitelist, I guess. I wouldn't invest any effort until we get a complaint.

Changed all to any and updated the tests.

bstaletic

Unfortunately, CI is currently broken.

Reviewed 2 of 3 files at r2.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale)

Valloric

Thanks for the PR!

People want it, so why not.

Reviewable status: 1 of 2 LGTMs obtained (and 1 stale)

puremourning

too.

Reviewable status: complete! 2 of 2 LGTMs obtained (and 1 stale)

Valloric · 2018-07-06T15:52:14Z

@zzbot r+

zzbot · 2018-07-06T15:52:15Z

📌 Commit 81035c1 has been approved by Valloric

zzbot · 2018-07-06T15:52:18Z

⌛ Testing commit 81035c1 with merge cebcc50...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T15:52:21Z

⌛ Testing commit 81035c1 with merge e84e471...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T15:58:54Z

⌛ Testing commit 81035c1 with merge e1bf888...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T16:03:37Z

⌛ Testing commit 81035c1 with merge bc30483...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T16:11:13Z

⌛ Testing commit 81035c1 with merge 7fc3fbf...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T16:11:55Z

⌛ Testing commit 81035c1 with merge 5b41913...

[RFC] Add option to disable the filepath completer This PR adds the option `filepath_blacklist` to allow users to disable the filepath completer from triggering on the `/` character (and `\` on Windows) for a list of filetypes. This option works like [the `filetype_blacklist` option](https://github.com/Valloric/YouCompleteMe#the-gycm_filetype_blacklist-option) where keys are the filetypes for which the completer should be disabled and the values are unimportant. The special key `*` can be used to blacklist all filetypes. Contrarily to the `filetype_*` options, there is no `filepath_whitelist` counterpart as I don't really see the use case but nothing prevents us from adding it later. The `html`, `jsx`, and `xml` filetypes are blacklisted by default as there are the ones mentioned in issues ycm-core/YouCompleteMe#708 and ycm-core/YouCompleteMe#3057. There are probably other filetypes that should be ignored by default but they can always be added later. The next step is to give a way to manually trigger filepath completion through a mapping so that even if the `filepath_blacklist` option is set for a filetype, it's still possible to trigger filepath completion. See issue ycm-core/YouCompleteMe#986. Closes ycm-core/YouCompleteMe#708. Closes ycm-core/YouCompleteMe#3057.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1061)

zzbot · 2018-07-06T22:43:26Z

☀️ Test successful - status-appveyor, status-travis
Approved by: Valloric
Pushing 5b41913 to master...

zzbot · 2018-07-07T02:11:13Z

💥 Test timed out

[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1028: rewrite Python completer; - PR ycm-core/ycmd#1035: prioritize compilation database over global extra conf; - PR ycm-core/ycmd#1036: use TypeScript completer for JavaScript; - PR ycm-core/ycmd#1038: fix GetDoc command on symbols declared in system headers; - PR ycm-core/ycmd#1039: handle FlagsForFile returning nothing; - PR ycm-core/ycmd#1049: update Unicode Standard to 11.0.0; - PR ycm-core/ycmd#1051: inform user if maximum number of diagnostics is exceeded; - PR ycm-core/ycmd#1052: add the regex module to sys.path in ycmd exclusively; - PR ycm-core/ycmd#1056: include Jedi performance improvements; - PR ycm-core/ycmd#1057: migrate the Clang completer to Settings in extra conf; - PR ycm-core/ycmd#1058: use node only if tsserver is supposed to run through it; - PR ycm-core/ycmd#1061: add option to disable the filepath completer. Documentation will be updated in separate PRs for ycm-core/ycmd#1028, ycm-core/ycmd#1036, ycm-core/ycmd#1057, and ycm-core/ycmd#1061. Closes #3067.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3082)

[READY] Add g:ycm_filepath_blacklist option to documentation See PR ycm-core/ycmd#1061.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3087)

micbou mentioned this pull request Jul 4, 2018

No way to turn off "filepath completer" in '.vimrc' ycm-core/YouCompleteMe#708

Closed

bstaletic requested changes Jul 4, 2018

View reviewed changes

micbou commented Jul 4, 2018

View reviewed changes

micbou changed the title ~~[RFC] Add option to disable the filepath completer~~ [NOT READY] Add option to disable the filepath completer Jul 4, 2018

bstaletic requested changes Jul 4, 2018

View reviewed changes

Add filepath_blacklist option

81035c1

Add an option to disable the filepath completer by filetype.

micbou force-pushed the filepath-completer-blacklist branch from 27b37e6 to 81035c1 Compare July 4, 2018 21:27

micbou commented Jul 4, 2018

View reviewed changes

micbou changed the title ~~[NOT READY] Add option to disable the filepath completer~~ [RFC] Add option to disable the filepath completer Jul 4, 2018

bstaletic approved these changes Jul 4, 2018

View reviewed changes

Valloric approved these changes Jul 5, 2018

View reviewed changes

puremourning approved these changes Jul 5, 2018

View reviewed changes

zzbot merged commit 81035c1 into ycm-core:master Jul 6, 2018

micbou deleted the filepath-completer-blacklist branch July 8, 2018 10:56

micbou mentioned this pull request Jul 20, 2018

[READY] Update ycmd ycm-core/YouCompleteMe#3082

Merged

micbou mentioned this pull request Jul 24, 2018

[READY] Add g:ycm_filepath_blacklist option to documentation ycm-core/YouCompleteMe#3087

Merged

puremourning mentioned this pull request Aug 4, 2018

Support path autocompletion for javascript.jsx filetypes ycm-core/YouCompleteMe#3102

Closed

12 tasks

Conversation

micbou commented Jul 4, 2018 • edited by Valloric Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bstaletic left a comment

Choose a reason for hiding this comment

Uh oh!

micbou left a comment

Choose a reason for hiding this comment

Uh oh!

bstaletic left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 4, 2018

Codecov Report

Uh oh!

micbou left a comment

Choose a reason for hiding this comment

Uh oh!

bstaletic left a comment

Choose a reason for hiding this comment

Uh oh!

Valloric left a comment

Choose a reason for hiding this comment

Uh oh!

puremourning left a comment

Choose a reason for hiding this comment

Uh oh!

Valloric commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 6, 2018

Uh oh!

zzbot commented Jul 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

micbou commented Jul 4, 2018 •

edited by Valloric

Loading