[bug] Buffer overflow when building portal file name from command line argument in vvis's RunVVis

[dimhotepus]

sprintf is used to build portal file name from argv[i]:

source-sdk-2013/src/utils/vvis/vvis.cpp

Line 1170 in 0759e2e

sprintf ( portalfile, "%s%s", inbase, argv[i] );

where portalfile is defined as char array of 1024 length:

source-sdk-2013/src/utils/vvis/vvis.cpp

Line 1085 in 0759e2e

char portalfile[1024];

When you pass argv[i] command line argument with length >= 1024 you overflow portalfile buffer.

Use tier1/strtools.h V_sprintf_safe to prevent buffer overflow.

[dimhotepus]

#832 (comment)

Closing as fixes from commercial static analyzer are not allowed.