Skip to content

Conversation

XkunW
Copy link
Contributor

@XkunW XkunW commented Sep 30, 2025

PR Type

[Fix]

Short Description

Move REQUIRED_ARGS from _client_vars to environment.yaml so that for different clusters user can define different required arguments

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.47%. Comparing base (20e299b) to head (644c6e1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          14       14           
  Lines        1232     1232           
=======================================
  Hits         1127     1127           
  Misses        105      105           
Files with missing lines Coverage Δ
vec_inf/client/_client_vars.py 100.00% <ø> (ø)
vec_inf/client/_slurm_vars.py 79.06% <100.00%> (+0.49%) ⬆️
vec_inf/client/_utils.py 80.41% <100.00%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XkunW XkunW merged commit 5a8a079 into main Sep 30, 2025
7 checks passed
@XkunW XkunW deleted the bugfix/required_args_bon_echo branch September 30, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants