Skip to content

Conversation

@alex-w-99
Copy link
Contributor

@alex-w-99 alex-w-99 commented Nov 4, 2025

@alex-w-99 alex-w-99 linked an issue Nov 4, 2025 that may be closed by this pull request
@alex-w-99 alex-w-99 marked this pull request as ready for review November 5, 2025 00:31
Copy link
Contributor

@dimavrem22 dimavrem22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after addressing comment below

@dimavrem22
Copy link
Contributor

INFO:__main__:
----------------------------------------------------------------------------------------------------
INFO:__main__:Starting routine discovery for task:
recover the api endpoints for searching for round trip flights and their prices
INFO:__main__:----------------------------------------------------------------------------------------------------

INFO:__main__:Context manager initialized.
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/vector_stores "HTTP/1.1 200 OK"
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/files "HTTP/1.1 200 OK"
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/vector_stores/vs_690acf5de2e48191a0138980b65659f1/files "HTTP/1.1 200 OK"

I feel like I am not in love with the logger prints being generated. It looks harder to keep a pretty format (not that what I was printing before was necessarily 'pretty')

thoughts?

@alex-w-99
Copy link
Contributor Author

INFO:__main__:
----------------------------------------------------------------------------------------------------
INFO:__main__:Starting routine discovery for task:
recover the api endpoints for searching for round trip flights and their prices
INFO:__main__:----------------------------------------------------------------------------------------------------

INFO:__main__:Context manager initialized.
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/vector_stores "HTTP/1.1 200 OK"
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/files "HTTP/1.1 200 OK"
INFO:httpx:HTTP Request: POST https://api.openai.com/v1/vector_stores/vs_690acf5de2e48191a0138980b65659f1/files "HTTP/1.1 200 OK"

I feel like I am not in love with the logger prints being generated. It looks harder to keep a pretty format (not that what I was printing before was necessarily 'pretty')

thoughts?

Okay, good point. I've updated the code so that all loggers use new Config attributes Config.LOG_DATE_FORMAT and Config.LOG_FORMAT.

If you want to get rid of the logging format, you can simply set those values to None and all logs will appear like print statements, no metadata.

Updates in commit 0217c80.

@alex-w-99 alex-w-99 merged commit 968cc06 into main Nov 5, 2025
1 check passed
@alex-w-99 alex-w-99 deleted the fix_param_usage_regex branch November 5, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Param validation fails for bare placeholders in URLs (Routine.validate_parameter_usage) Centrally manage logging level in Config [EOM]

3 participants