-
Notifications
You must be signed in to change notification settings - Fork 1
v1.1.0: Restructure package and make it PyPI publishable #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Re: "pip-installable" -- my understanding is that python package installers like pip, uv, etc. default use PyPI under the hood. Assuming that this PR is actually about PyPI and nothing specific to do with pip? |
Renamed the PR title to make it more accurate |
Resolved in commit fe5ed52 |
Does this update (#45 (comment)) address your question? |
Co-authored-by: Alex Wilcox <98042559+alex-w-99@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when closing the monitoring tab using x and not command C, the monitoring does not gracefully stop.. it fails to generate the condesed_transactions.json.
this should be another way to end the monitoring. this issue is not introduced by this PR. I can address this in a latter patch, if you prefer.
But at least, if a step fails, the whole pipeline should exit. In this case, from previous web-hacker run, i already had a routine.json so this is why the pipeline continued:
# Step 4: Execute (optional)
routine_file = ROUTINE_OUTPUT / "routine.json"
if not routine_file.exists():
print_colored(f"⚠️ Routine not found at {routine_file}", YELLOW)
return
print_colored("Step 4: Ready to execute routine!", GREEN)
the suggestion below would address this
#45 (comment)
Enabled graceful exit when the user closes the monitored tab in commit: b5dfdf1 |
|
optional: if this script launched chrome in debug mode, should this also be responsible for closing it? |
quickstart will close chrome now, updated in commit 14b5d78 |
added high-level context in commit da0522e |
dimavrem22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG








Overview
Restructures
web-hackerto make it PyPI publishable. The package is now publicly available onTestPyPI.To test the
TestPyPIinstallation, runOnce this PR is merged to
main, I will make it available viapip install web-hackerand create a github release.High-Level SDK
CLI Commands
web-hacker-monitor- Monitor browser activityweb-hacker-discover- Discover routinesweb-hacker-execute- Execute routinesChanges
Import paths changed:
Script execution:
src/→web_hacker/(proper Python package)scripts/→web_hacker/scripts/web_hacker/sdk/with wrapper classes (WebHacker,BrowserMonitor, etc.)pyproject.tomlwith package metadata and CLI entry points1.1.0Note: Core functionality unchanged. Only import paths changed. The SDK is a wrapper around existing functionality.