Skip to content

Add ScreenSharing#14

Merged
Vendicated merged 9 commits into
mainfrom
screenshare
Jun 21, 2023
Merged

Add ScreenSharing#14
Vendicated merged 9 commits into
mainfrom
screenshare

Conversation

@Vendicated
Copy link
Copy Markdown
Member

@Vendicated Vendicated commented Apr 15, 2023

Not finished or particularly pretty yet but already functional!

This will close #1

image

2023-04-15.23-15-07.mp4

@TeaSpillStudios
Copy link
Copy Markdown

This looks awesome. Is there any further work that needs to be done on this and is there an ETA on when it will be merged?

@Vendicated
Copy link
Copy Markdown
Member Author

Vendicated commented Apr 30, 2023

This looks awesome. Is there any further work that needs to be done on this and is there an ETA on when it will be merged?

Yes, there is. Currently, it uses ur entire system audio (including discord), which means viewers can hear themselves in your stream. Additionally, currently it's not possible to customise resolution & fps. And the ui also needs to be improved

ETA is whenever it's done :P No idea, whenever I find time & motivation to work on it

@TeaSpillStudios
Copy link
Copy Markdown

Alright, thanks for answering!

@ardishko
Copy link
Copy Markdown

ardishko commented May 8, 2023

Yes, there is. Currently, it uses ur entire system audio (including discord), which means viewers can hear themselves in your stream.

Are you guys planning to fix this or is there a roadblock in the way that prevents this from working?

@Vendicated
Copy link
Copy Markdown
Member Author

Yes, there is. Currently, it uses ur entire system audio (including discord), which means viewers can hear themselves in your stream.

Are you guys planning to fix this or is there a roadblock in the way that prevents this from working?

"ETA is whenever it's done :P No idea, whenever I find time & motivation to work on it"

@ardishko
Copy link
Copy Markdown

ardishko commented May 9, 2023

Yes, there is. Currently, it uses ur entire system audio (including discord), which means viewers can hear themselves in your stream.

Are you guys planning to fix this or is there a roadblock in the way that prevents this from working?

"ETA is whenever it's done :P No idea, whenever I find time & motivation to work on it"

Fair enough, I wasn't trying to ask about an ETA but that's still a fair enough answer..

@ELHIFFROST
Copy link
Copy Markdown

so, when is a BETA going to be available?

@enderpuff
Copy link
Copy Markdown

Will this work on linux? It would be great if you guys could do that, as not even the official client seems to work right now, and i have to use a separate client to make screen sharing work at all (discord-screenaudio)

@ardishko
Copy link
Copy Markdown

ardishko commented May 17, 2023

Will this work on linux? It would be great if you guys could do that, as not even the official client seems to work right now, and i have to use a separate client to make screen sharing work at all (discord-screenaudio)

I second this. That's why I'm also curious about Wayland screensharing and audio.

@Vendicated
Copy link
Copy Markdown
Member Author

It just uses electron's screenshare api. It either works or doesn't work. If it doesn't work, I won't go an extra mile to somehow fix it as there are multiple other projects that focus on this already

@Vendicated Vendicated marked this pull request as ready for review June 21, 2023 18:47
@Vendicated Vendicated changed the title Add screenshare capabilities Add ScreenSharing Jun 21, 2023
@Vendicated Vendicated merged commit 2532779 into main Jun 21, 2023
@Vendicated Vendicated deleted the screenshare branch June 21, 2023 18:52
@ardishko
Copy link
Copy Markdown

ardishko commented Jun 22, 2023

Tried on Wayland, does not work. This is basically a "won't fix" type of deal so Wayland users are taking another L today. May god bless pipewire screensharing.

Also the audio is only for Windows so that's kinda sad for all Linux users.

@ardishko
Copy link
Copy Markdown

ardishko commented Jun 23, 2023

there are multiple other projects that focus on this already

Well, yes, you are right but I think I speak for the most of us when I say that most people aren't a big fan of having another Discord client open just to screenshare properly.

You aren't obligated to do anything about this of course but I just wanted to let you know that it isn't completely pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Streaming

5 participants