Skip to content

feat: use standardized icon for macOS#48

Merged
Vendicated merged 4 commits into
Vencord:mainfrom
ryanccn:macos-standard-icons
Jul 27, 2023
Merged

feat: use standardized icon for macOS#48
Vendicated merged 4 commits into
Vencord:mainfrom
ryanccn:macos-standard-icons

Conversation

@ryanccn
Copy link
Copy Markdown
Contributor

@ryanccn ryanccn commented Jul 8, 2023

Designed using Apple's official Sketch design template.

@ryanccn ryanccn force-pushed the macos-standard-icons branch from 26d3f72 to afa5bec Compare July 8, 2023 07:04
@Vendicated
Copy link
Copy Markdown
Member

what's the difference?

@ryanccn
Copy link
Copy Markdown
Contributor Author

ryanccn commented Jul 8, 2023

@Vendicated it uses the rounded square icon format that has been the standard from Big Sur onwards

@Vendicated
Copy link
Copy Markdown
Member

please show a screenshot

@ryanccn ryanccn force-pushed the macos-standard-icons branch from ce98b47 to 802dafc Compare July 9, 2023 09:08
@ryanccn
Copy link
Copy Markdown
Contributor Author

ryanccn commented Jul 9, 2023

CleanShot 2023-07-09 at 17 11 32@2x

@Vendicated
Copy link
Copy Markdown
Member

This code doesn't seem right. You removed the setDock line and MACOS_ICON_PATH seems unused

@ryanccn
Copy link
Copy Markdown
Contributor Author

ryanccn commented Jul 14, 2023

Yeah that constant can probably be removed, you don’t need a setIcon call on macOS

@Vendicated
Copy link
Copy Markdown
Member

i think the static icon shouldnt be needed anymore?

i also think this icon would also apply to other platforms, so maybe rename the file to build/icon.macos.icns and specify in package.json electron-builder config

@ryanccn
Copy link
Copy Markdown
Contributor Author

ryanccn commented Jul 27, 2023

i think the static icon shouldnt be needed anymore?

yes, I'll remove that

i also think this icon would also apply to other platforms, so maybe rename the file to build/icon.macos.icns and specify in package.json electron-builder config

it wouldn't, icns is a macOS-specific format

@Vendicated
Copy link
Copy Markdown
Member

i also think this icon would also apply to other platform

image

@Vendicated Vendicated closed this Jul 27, 2023
@Vendicated
Copy link
Copy Markdown
Member

WRONG BUTTON

@Vendicated Vendicated reopened this Jul 27, 2023
@Vendicated Vendicated enabled auto-merge (squash) July 27, 2023 01:03
@Vendicated Vendicated merged commit 08090e3 into Vencord:main Jul 27, 2023
@ryanccn ryanccn deleted the macos-standard-icons branch July 27, 2023 01:03
@Vendicated
Copy link
Copy Markdown
Member

thank u btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants