Fix 1.8->1.9 window items translation

FlorianMichael · FlorianMichael · commit c7e638fc70b7 · 2024-04-27T13:58:42.000+02:00
diff --git a/common/src/main/java/com/viaversion/viarewind/protocol/protocol1_8to1_9/packets/BlockItemPackets1_9.java b/common/src/main/java/com/viaversion/viarewind/protocol/protocol1_8to1_9/packets/BlockItemPackets1_9.java
@@ -87,7 +87,7 @@ protected void registerPackets() {
 		protocol.registerClientbound(ClientboundPackets1_9.WINDOW_ITEMS, wrapper -> {
 			final short windowId = wrapper.passthrough(Type.UNSIGNED_BYTE);
 
-			Item[] items = wrapper.passthrough(Type.ITEM1_8_SHORT_ARRAY);
+			Item[] items = wrapper.read(Type.ITEM1_8_SHORT_ARRAY);
 			for (int i = 0; i < items.length; i++) {
 				items[i] = handleItemToClient(wrapper.user(), items[i]);
 			}
@@ -107,6 +107,8 @@ protected void registerPackets() {
 					System.arraycopy(old, 5, items, 4, old.length - 5);
 				}
 			}
+
+			wrapper.write(Type.ITEM1_8_SHORT_ARRAY, items);
 		});
 
 		protocol.registerClientbound(ClientboundPackets1_9.SET_SLOT, wrapper -> {

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ protected void registerPackets() {`
`87`	`87`	`protocol.registerClientbound(ClientboundPackets1_9.WINDOW_ITEMS, wrapper -> {`
`88`	`88`	`final short windowId = wrapper.passthrough(Type.UNSIGNED_BYTE);`
`89`	`89`
`90`		`- Item[] items = wrapper.passthrough(Type.ITEM1_8_SHORT_ARRAY);`
	`90`	`+ Item[] items = wrapper.read(Type.ITEM1_8_SHORT_ARRAY);`
`91`	`91`	`for (int i = 0; i < items.length; i++) {`
`92`	`92`	`items[i] = handleItemToClient(wrapper.user(), items[i]);`
`93`	`93`	`}`
`@@ -107,6 +107,8 @@ protected void registerPackets() {`
`107`	`107`	`System.arraycopy(old, 5, items, 4, old.length - 5);`
`108`	`108`	`}`
`109`	`109`	`}`
	`110`	`+`
	`111`	`+ wrapper.write(Type.ITEM1_8_SHORT_ARRAY, items);`
`110`	`112`	`});`
`111`	`113`
`112`	`114`	`protocol.registerClientbound(ClientboundPackets1_9.SET_SLOT, wrapper -> {`