Skip to content

Commit ee69005

Browse files
Delete temporary fix for shulker box window titles
Properly fixed by ViaVersion/ViaBackwards#761
1 parent 740a6d9 commit ee69005

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/BlockItemPacketRewriter1_9.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626
import com.viaversion.viaversion.api.minecraft.item.Item;
2727
import com.viaversion.viaversion.api.protocol.remapper.PacketHandlers;
2828
import com.viaversion.viaversion.api.type.Types;
29-
import com.viaversion.viaversion.libs.gson.JsonElement;
30-
import com.viaversion.viaversion.libs.gson.JsonParser;
3129
import com.viaversion.nbt.tag.*;
3230
import com.viaversion.viaversion.protocols.v1_8to1_9.data.EntityIds1_8;
3331
import com.viaversion.viaversion.protocols.v1_8to1_9.data.PotionIdMappings1_9;
@@ -77,17 +75,8 @@ protected void registerPackets() {
7775
protocol.registerClientbound(ClientboundPackets1_9.OPEN_SCREEN, wrapper -> {
7876
final short windowId = wrapper.passthrough(Types.UNSIGNED_BYTE);
7977
final String windowType = wrapper.passthrough(Types.STRING);
80-
final JsonElement windowTitle = wrapper.passthrough(Types.COMPONENT);
8178

8279
wrapper.user().get(WindowTracker.class).put(windowId, windowType);
83-
84-
// TODO This is wrong, VB is missing pre 1.13 mappings for translations
85-
if (windowType.equalsIgnoreCase("minecraft:shulker_box")) {
86-
wrapper.set(Types.STRING, 0, "minecraft:container");
87-
}
88-
if (windowTitle.toString().equalsIgnoreCase("{\"translate\":\"container.shulkerBox\"}")) {
89-
wrapper.set(Types.COMPONENT, 0, JsonParser.parseString("{\"text\":\"Shulker Box\"}"));
90-
}
9180
});
9281

9382
protocol.registerClientbound(ClientboundPackets1_9.CONTAINER_SET_CONTENT, wrapper -> {

0 commit comments

Comments
 (0)