-
Notifications
You must be signed in to change notification settings - Fork 4
Merge fix-issue33 with master to fix issue #33. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Additionally, fixes string concatenation in a loop used as a parameter, which comes with undesired side effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make stackexchange the if-case and handle the problematic login in a separate method?
Currently trying to login with openid results in a SAXParseException, because the HTML of the login page is invalid:
With the following stacktrace:
|
This cannot be completed as of now, since the used DOM-Parser is not resilient enough to properly parse the served login pages for the required data. Unbalanced Tags should be ignored or corrected on a best-effort basis when parsing malformed HTML as it is served on the relevant login pages. |
Deferred until further notice, because completion of http://github.com/Unihedro/JChatExchange makes this moot |
I'm not sure if it actually works consistently though, and plus it could sure use a review. I've used HTTP requests instead of using the browser window of HTMLUnit, as the Stack Exchange login page generates a dynamic iframe, which is not possible to handle directly. Since the login method stands out of its own as it doesn't use the browser, I've isolated the code into its own method and called it when necessary.