Skip to content

Fix/issue 105 js override error #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix/issue 105 js override error #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d97a9
fix: disable allowJs and checkJs in base config
sushichan044 May 24, 2024
6bd7090
chore: changeset
sushichan044 May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-gifts-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@virtual-live-lab/tsconfig": patch
---

Disable allowJs and checkJs by default
2 changes: 0 additions & 2 deletions packages/tsconfig/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
"module": "Node16",
"moduleResolution": "Node16",
"resolveJsonModule": true,
// js support
"checkJs": true,
// interop
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
Expand Down
8 changes: 6 additions & 2 deletions packages/tsconfig/docs/base/compiler-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,11 +487,15 @@ JavaScriptファイルをTypeScriptファイルへimportすることを許可す

### [Check Js](https://www.typescriptlang.org/ja/tsconfig/#checkJs)

設定値: `true`
設定値: `false (default)`

JavaScriptファイルにおいてもTypeScriptと同等の型チェックをするかどうか設定する。

基本的には`true`にしておく。
~~基本的には`true`にしておく。~~

\#105のように、`tsc`がJavaScriptファイルもトランスパイルしようとしてOverwriteエラーが発生してしまうので、`false`にしておく。

なお、JavaScriptでも型チェックが必要な場合は`// @ts-check`をファイルの先頭に書くことで有効にできる。

### [Max Node Module JS Depth](https://www.typescriptlang.org/ja/tsconfig/#maxNodeModuleJsDepth)

Expand Down