Skip to content

Fix/tooltip position and style #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix/tooltip position and style #3555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebef8d
fix: fix style of dom tooltip
xile611 Dec 12, 2024
388e002
docs: update changlog of rush
xile611 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-tooltip-position-and-style_2024-12-12-03-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix style of dom tooltip\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
1 change: 1 addition & 0 deletions packages/vchart/src/plugin/components/tooltip-handler/dom-tooltip-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ export class DomTooltipHandler extends BaseTooltipHandler {

if (contentDom && hasContent) {
const columnDivs = [...(contentDom.children as any)] as HTMLElement[];
setStyleToDom(contentDom, { whiteSpace: 'nowrap' });

columnDivs.forEach((colDiv, index) => {
const colName = colDiv.getAttribute('data-col');
Expand Down
2 changes: 1 addition & 1 deletion packages/vchart/src/plugin/components/tooltip-handler/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const getScale = (element: HTMLElement, boundingClientRect?: DOMRect) =>
if (element.offsetWidth > 0) {
return boundingClientRect.width / element.offsetWidth;
}
return boundingClientRect.height / element.offsetHeight;
return element.offsetHeight > 0 ? boundingClientRect.height / element.offsetHeight : 1;
};

export const formatContent = (content: any) => {
Expand Down
Loading