Skip to content

fix: fix bug of vchar theme demo #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

fix: fix bug of vchar theme demo #4313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions docs/assets/examples/en/theme/theme-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,8 @@ const spec = {
]
};

const getNewTheme = async () => {
const theme = // your custom theme
(
await import('https://www.unpkg.com/@visactor/vchart-theme@latest/public/dark.json', {
assert: { type: 'json' }
})
).default;
return theme;
};

const newTheme = await getNewTheme();
const response = await fetch('https://www.unpkg.com/@visactor/vchart-theme@latest/public/dark.json');
const newTheme = await response.json();

// 注册主题
VChart.ThemeManager.registerTheme('user', newTheme);
Expand Down
13 changes: 2 additions & 11 deletions docs/assets/examples/zh/theme/theme-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,8 @@ const spec = {
]
};

const getNewTheme = async () => {
const theme = // your custom theme
(
await import('https://www.unpkg.com/@visactor/vchart-theme@latest/public/dark.json', {
assert: { type: 'json' }
})
).default;
return theme;
};

const newTheme = await getNewTheme();
const response = await fetch('https://www.unpkg.com/@visactor/vchart-theme@latest/public/dark.json');
const newTheme = await response.json();

// 注册主题
VChart.ThemeManager.registerTheme('user', newTheme);
Expand Down
Loading