Fix for issue 317 #240
Merged
Fix for issue 317 #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashidlos
requested changes
Oct 8, 2021
| <IconButton | ||
| disabled={!selectedRectId || ignoreAreas.length === 0} | ||
| onClick={() => applyIgnoreArea()} | ||
| onClick={() => setApplyIgnoreDialogOpen(!applyIgnoreDialogOpen)} |
Member
There was a problem hiding this comment.
could reuse toggleApplyIgnoreDialogOpen?
| /> | ||
| <BaseModal | ||
| open={applyIgnoreDialogOpen} | ||
| title={''} |
Member
There was a problem hiding this comment.
you could reuse text from tooltip
line 362Apply selected ignore area to all images in this build.
| onCancel={toggleApplyIgnoreDialogOpen} | ||
| content={ | ||
| <Typography> | ||
| {`Are you sure you want to apply ignore area to all items in this build?`} |
Member
There was a problem hiding this comment.
drop a note that all images gonna be re-compared with new ignore area taken into account
Collaborator
Author
|
Fixed review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Visual-Regression-Tracker/Visual-Regression-Tracker#317