Skip to content

Conversation

@paazmaya
Copy link
Contributor

Perhaps fixes #310?

@paazmaya paazmaya requested a review from pashidlos July 19, 2023 20:08
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paazmaya paazmaya merged commit 5c6b220 into master Jul 24, 2023
@paazmaya paazmaya deleted the 310-bash-script-to-nodejs branch July 24, 2023 11:45
@ghost
Copy link

ghost commented Nov 20, 2023

Hi @pashidlos I'm not sure what's happened with the pr above, but the changes don't seem to have been merged into master - the new generate-env-browser.js file isn't present, nor any of the other changes.

@pashidlos
Copy link
Member

@polyvisual it was rolled back
alpine docker image doesn't have node installed to run those scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot start front end on Linux or Windows WSL

3 participants