-
Notifications
You must be signed in to change notification settings - Fork 256
Language configuration #170
Conversation
Very interesting. This trigged recaptcha to fetch the language specific version of the script. (Previously, people have been trying to swap the scripts) I am not sure if that is a new capability or not. |
src/service.js
Outdated
* Set reCaptcha language | ||
*/ | ||
setLang: function (widgetId, lang) { | ||
var cli = window.___grecaptcha_cfg.clients[widgetId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find this object at: https://www.google.com/recaptcha/api.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
things that start with _
and especially __
and even more so ___
are internal methods and should not be relied upon by third parties as they can change or disappear. window.grecaptcha
is the official api.
Furthermore, variable names like W
and wk
should not be replied upon because those are generated by the build process and will change build to build, version to version.
@reduardo7 First, I want to thank you for the PR. I subscribe to what @TheSharpieOne mentioned, and I would like to add that all your changes must be performed on the files in the Lastly, it would be awesome to have some tests included in the PR for the new feature. |
@iambrosi and @TheSharpieOne : I have made the suggested changes, but I notice that the automatic integration test is failing for something that does not seem to be related to my work. |
The issue is with the CI, travis.yml is set to use the latest stable version of node. That combined with out-dated devDep makes it not work. Also, I did test the merge result of this PR locally with the updated devDeps; everything passed. |
chore(deps): update devDeps
chore(coverage): report coverage on CI build
Changes Unknown when pulling a5a1f25 on reduardo7:master into ** on VividCortex:master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @reduardo7 ! |
@iambrosi I agree with #170 (comment), but now the Issue: #173 |
Fixes #167, #141