Align with Grafana 4.6.0 plug-in changes #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to the latest version of Grafana 4.6.0 will render all instances of Status Panel inoperable as access to internal Grafana components has been restricted (see #81). The following error is now shown on any dashboard using this panel:
This is due to two imports at the start of status_ctrl.js:
It looks like these imports are legacy and no longer referenced within the module. Removing the two lines appears to fix the issue. @TomerAmirV , I have done some initial testing to confirm this works and doesn't break anything obvious but would appreciate if you could double-check and let me know if I've missed something. Happy to follow up as needed.
Also in 4.6.0, the angularjs element <spectrum-picker> is being depreciated in favour of the new <color-picker>. This PR updates editor.html to use the new picker. See Grafana Release Notes for further information.