Skip to content

Conversation

@JesseObrien
Copy link
Contributor

This is broken in the current @beta composer release. All of these classes will break (read: FATAL error) when being used because they don't implement the abstract method signature properly.

Method signature declaration here:
https://github.com/Nexmo/nexmo-php/blob/master/src/Entity/EntityInterface.php#L16

@tjlytle
Copy link
Contributor

tjlytle commented Jan 5, 2017

Thanks, this was a bit of a refactor from an earlier concept, so had not paid enough attention. Will merge, should also mention the next release will change some of the underlying request / response concepts. Hope your use was just to get it to work, and not utilizing the underlying request / response data.

@tjlytle tjlytle merged commit 1ac4952 into Vonage:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants