Skip to content

Conversation

@superchilled
Copy link
Contributor

Reason for this PR

The Verify API has a new possible error response for the https://api.nexmo.com/verify/json, which can return a response with and without certain properties in the response body. This PR is to ensure that the existing implementation of Verify in the Ruby SDK handles the various permutations of this response correctly. See this JIRA ticket for additional context.

What this PR does

  • Adds three tests to verify_test.rb:
    • One to check an blacklist error response with network but not request_id
    • One to check an blacklist error response with request_id but not network
    • One to check an blacklist error response with request_id and network

@codecov-commenter
Copy link

Codecov Report

Merging #241 (7091849) into dev (4169c8a) will not change coverage.
The diff coverage is n/a.

❗ Current head 7091849 differs from pull request most recent head 5973806. Consider uploading reports for the commit 5973806 to get more accurate results

@@           Coverage Diff           @@
##              dev     #241   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          70       70           
  Lines        1401     1401           
=======================================
  Hits         1369     1369           
  Misses         32       32           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superchilled
Copy link
Contributor Author

LGTM

@dragonmantank GitHub is saying that you requested changes, but I can't see what.

Copy link

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why Github keeps doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants