Skip to content

Conversation

@superchilled
Copy link
Contributor

@superchilled superchilled commented Nov 22, 2022

  • Updates the gemspec to change JWT dependency from nexmo-jwt to vonage-jwt
  • Updates CI GitHub Action to test on supported Ruby version 3.1

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #251 (61675b2) into dev (099e925) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #251   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          71       71           
  Lines        1457     1457           
=======================================
  Hits         1424     1424           
  Misses         33       33           
Impacted Files Coverage Δ
lib/vonage/jwt.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SecondeJK
Copy link

I hope that token is all good!

@superchilled
Copy link
Contributor Author

I hope that token is all good!

Yep. I had to update the hard-coded token because the new JWT library includes typ and alg in the header rather than the payload, so the encoding is different. I've double checked it to make sure it decodes correctly.

@superchilled superchilled merged commit 69e0e7a into dev Nov 28, 2022
@superchilled superchilled deleted the devx-6617-update-gemspec-jwt-dependency branch November 28, 2022 14:52
This was referenced Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants