fix(VueDatePicker): menu not opening when centered prop is enabled #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the centered prop is enabled, the datepicker menu does not open after clicking the input. The issue was caused by the shouldRender ref being initialized as false for non-inline modes, preventing the menu from rendering even when isOpen was true. Modified shouldRender initialization to include rootProps.centered condition. Now shouldRender is true when either inline.enabled or rootProps.centered is active. The existing watcher logic remains unchanged and only affects floating (non-centered, non-inline) mode. Added test case to verify menu opens correctly in centered mode. Changes: - VueDatePicker.vue - TestSuite_1.spec.ts Fixes #1195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The datepicker menu did not open when the
centeredprop was enabled becauseshouldRenderwas initialized asfalsefor all non-inline modes. This prevented the menu from rendering whenisOpenbecametrue.This PR updates the initialization so that
shouldRenderbecomestruewhen eitherinline.enabledorrootProps.centeredis active. This ensures the menu opens correctly in centered mode.A minimal unit test was added to verify that the menu renders when
centered: trueis enabled.Issue ticket number and link
Fixes #1195
Checklist before requesting a review