Skip to content

Fix to Northwood Staff throwing an exception #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

Fix to Northwood Staff throwing an exception #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e213202
Removed printout of the api key in logs
Vxrpenter May 23, 2025
9c76b49
Fix #1, replacing every `"Nickname":false` scenario (temporary)
Vxrpenter May 23, 2025
4b4d38f
remove unused imports
Vxrpenter May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/kotlin/io/github/vxrpenter/secretlab/SecretLab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,16 @@ class SecretLab(private val apiKey: String, private val accountId: String, readT

try {
client.newCall(request).execute().use { response ->
logCall(request.url.toString(), response.isSuccessful, response.code, response.message)
val obj = Json.decodeFromString<ServerInfo>(response.body!!.string())
logCall(request.url.toString().replace(apiKey, "keyRemovedForPrivacyReasons"), response.isSuccessful, response.code, response.message)
val responseBody = response.body!!.string().replace("\"Nickname\":false", "\"Nickname\":\"Could not fetch\"")
val obj = Json.decodeFromString<ServerInfo>(responseBody)

obj.response = getResponseTime(response)
return obj
}
} catch (e: Exception) {
throw CallFailureException("Failed to get server info from ${request.url}", e)
}
catch (e: Exception) {
throw CallFailureException("Failed to get server info from ${request.url.toString().replace(apiKey, "keyRemovedForPrivacyReasons")}", e)
}
}

Expand Down Expand Up @@ -77,6 +79,8 @@ class SecretLab(private val apiKey: String, private val accountId: String, readT
return (received-sent)
}



private fun logCall(requestUrl: String, successful: Boolean, exitCode: Int, statusMessage: String) {
if (successful) {
logger.debug("Request to $requestUrl was successful with exitcode $exitCode $statusMessage")
Expand Down