Skip to content

Conversation

@j-fu
Copy link
Member

@j-fu j-fu commented Sep 24, 2022

Sparspak.jl provides support for general floats and is MIT licensed. So we can define \ and ldiv! for ExtendableSparseMatrix, and also as an alternative for the non-GPL case.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022

Codecov Report

Base: 85.15% // Head: 83.20% // Decreases project coverage by -1.95% ⚠️

Coverage data is based on head (c0af0ec) compared to base (a4a5bc0).
Patch coverage: 80.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   85.15%   83.20%   -1.96%     
==========================================
  Files          17       18       +1     
  Lines         842     1012     +170     
==========================================
+ Hits          717      842     +125     
- Misses        125      170      +45     
Impacted Files Coverage Δ
src/ExtendableSparse.jl 100.00% <ø> (ø)
src/sprand.jl 71.17% <64.70%> (-5.16%) ⬇️
src/sparspak.jl 81.81% <66.66%> (-18.19%) ⬇️
src/SparspakCSCInterface.jl 81.87% <81.87%> (ø)
src/extendable.jl 62.99% <100.00%> (-0.72%) ⬇️
src/factorizations.jl 73.33% <100.00%> (ø)
src/sparsematrixlnk.jl 96.79% <0.00%> (-0.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@j-fu
Copy link
Member Author

j-fu commented Sep 24, 2022

Hi @bmmogensen, in this PR I changed the architecture for the non-GPL case:

  • Defined my own constant USE_GPL_LIBS in order to have a switch for at least some testing
  • Provide a Base.\ for ExtendableSparseMatrix relying on Sparspak.jl

May be you can check if this still works for you before I tag a new release, would wait a couple of days.

@j-fu j-fu merged commit a0a7c93 into master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants