feat(Get Classmate Work): Create endpoint for classmate Discussion work #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
29
to
31
| Run run = runService.retrieveById(runId); | ||
| Group period = groupService.retrieveById(periodId); | ||
| if (isAllowedToGetData(auth, run, period, nodeId, componentId)) { |
Member
There was a problem hiding this comment.
These lines are also in getClassmateDiscussionAnnotations(). Extract to method?
hirokiterashima
requested changes
Nov 8, 2021
Member
hirokiterashima
left a comment
hirokiterashima
left a comment
There was a problem hiding this comment.
Functionality works as described.
Here are my suggestions for improving code readability/testing:
- See comments/questions inline
- Revert changes where comments add extra lines
- Add tests for
- HibernateStudentWorkDao.getStudentWork()
- HibernateRunDao.isUserInRunAndPeriod()
- HibernateAnnotationDao.getAnnotations()
- ClassmatedataController methods
| import org.json.JSONException; | ||
| import org.json.JSONObject; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.core.env.Environment; |
| import org.wise.vle.domain.annotation.wise5.Annotation; | ||
| import org.wise.vle.domain.work.StudentWork; | ||
|
|
||
| public class ClassmateDataController { |
Member
There was a problem hiding this comment.
Would this class ever be instantiated by itself? Make into abstract class?
hirokiterashima
approved these changes
Nov 10, 2021
Member
Author
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion student work endpoint example
Discussion annotations endpoint example
Closes #51