Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Nov 30, 2021

Changes

Test

You can open the CM as

  • regular (non-admin) teacher, on your own run and shared runs
  • admin user, on any run

Closes #68

- The user object retrieved in the controller by DomainClassConverter
is now a HibernateProxy object due to PR #65, so I updated the User's
equal object to check for it.
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@geoffreykwan geoffreykwan merged commit b179815 into develop Nov 30, 2021
@geoffreykwan geoffreykwan deleted the issue-68-teacher-cant-open-grading-tool branch November 30, 2021 16:33
@geoffreykwan
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Teacher can't open grading tool

3 participants