Skip to content

refactor(UserAPIController): Extract RunInfoController #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2025
Merged

refactor(UserAPIController): Extract RunInfoController #296

merged 2 commits into from
May 24, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 8, 2025 •
edited
Loading

Changes

  • Moved methods and tests relating to "run info" from the Student and User API controllers into its own RunInfoAPIController class.

Test

  • For this to work, you'll also need this client PR: Updated URLs for RunInfoAPIController refactor WISE-Client#2132
  • To test the endpoint at api/run-info/run/info, go to 'Student Home,' click 'Add Unit,' and enter some text that isn't a valid access code. Click off to the side, and it should say "Invalid Access Code."
    • Then enter a valid access code, and the warning should go away.
  • To test the endpoint at api/run-info/run/info-by-id, go to 'Student Home' and click 'Report Problem' on any unit. The contact form should include a line showing the name of the project that you clicked on.
  • Make sure moved tests still pass.

Closes #292

@Aaron-Detre Aaron-Detre added the Code Quality Improves code quality label Apr 8, 2025
@Aaron-Detre Aaron-Detre self-assigned this Apr 8, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 8, 2025 16:10
hirokiterashima
hirokiterashima approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit 846266c into develop May 24, 2025
3 checks passed
@hirokiterashima hirokiterashima deleted the issue-292-run-info-controller branch May 24, 2025 01:18
@hirokiterashima
Copy link
Member

hirokiterashima commented May 29, 2025

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

Code Quality Improves code quality released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(UserAPIController): Extract RunInfoController

3 participants

@Aaron-Detre @hirokiterashima