Skip to content

fix(AT): Clicking lesson/step title does not check checkbox #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

fix(AT): Clicking lesson/step title does not check checkbox #2149

merged 3 commits into from
Apr 22, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 21, 2025

Changes

  • For lessons, clicking the title expands/collapses the lesson instead of checking the checkbox.
  • For steps, clicking the title opens the step editor instead of checking the checkbox.

Test

  • Clicking the titles no longer checks the checkbox, and instead does its new expected behavior.

Closes #2127

@Aaron-Detre Aaron-Detre self-assigned this Apr 21, 2025
@Aaron-Detre Aaron-Detre added the bug Something isn't working label Apr 21, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 21, 2025 17:22
hirokiterashima
hirokiterashima approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima changed the title Clicking lesson/step title does not check checkbox fix(AT): Clicking lesson/step title does not check checkbox Apr 21, 2025
@Aaron-Detre Aaron-Detre merged commit ceb0006 into develop Apr 22, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2127-cannot-open-step-on-phone branch April 22, 2025 17:50
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 22, 2025

🎉 This PR is included in version 5.177.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

bug Something isn't working released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(AT): Cannot open step when using phone

3 participants

@Aaron-Detre @hirokiterashima