Skip to content

fix(AT): Clicking lesson/step title does not check checkbox #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

fix(AT): Clicking lesson/step title does not check checkbox #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fa9410
Clicking step title opens step editor rather than checking checkbox
Aaron-Detre Apr 21, 2025
ee910c7
Clicking lesson title collapses/expands the lesson rather than checki…
Aaron-Detre Apr 21, 2025
a9a0cd3
Updated messages
github-actions[bot] Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...sets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
[disabled]="nodeTypeSelected() === 'step'"
aria-label="Select lesson"
i18n-aria-label
>
<node-icon-and-title [nodeId]="lesson.id" [showPosition]="showPosition" />
</mat-checkbox>
/>
<node-icon-and-title [nodeId]="lesson.id" [showPosition]="showPosition" />
</mat-panel-title>
<mat-panel-description class="text" fxLayoutAlign="end center" fxLayoutGap="4px">
<button
Expand Down
5 changes: 3 additions & 2 deletions src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@
[disabled]="nodeTypeSelected() === 'lesson'"
aria-label="Select step"
i18n-aria-label
>
/>
<strong>
<node-icon-and-title [nodeId]="step.id" [showPosition]="showPosition" />
</mat-checkbox>
</strong>
<div fxLayoutAlign="start center" fxLayoutGap="8px">
@if (isBranchPoint(step.id)) {
<button
Expand Down
26 changes: 13 additions & 13 deletions src/messages.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9686,7 +9686,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html</context>
<context context-type="linenumber">72,76</context>
<context context-type="linenumber">71,75</context>
</context-group>
</trans-unit>
<trans-unit id="2229114339431741749" datatype="html">
Expand Down Expand Up @@ -12640,28 +12640,28 @@ The branches will be removed but the steps will remain in the unit.</source>
<source>Edit lesson</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html</context>
<context context-type="linenumber">27,31</context>
<context context-type="linenumber">26,30</context>
</context-group>
</trans-unit>
<trans-unit id="6802950642532163491" datatype="html">
<source>Move lesson</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html</context>
<context context-type="linenumber">37,41</context>
<context context-type="linenumber">36,40</context>
</context-group>
</trans-unit>
<trans-unit id="2385664129371928026" datatype="html">
<source>Delete lesson</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html</context>
<context context-type="linenumber">47,51</context>
<context context-type="linenumber">46,50</context>
</context-group>
</trans-unit>
<trans-unit id="8466479820430643655" datatype="html">
<source>This lesson has no steps</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.component.html</context>
<context context-type="linenumber">67,71</context>
<context context-type="linenumber">66,70</context>
</context-group>
</trans-unit>
<trans-unit id="2751426191436053350" datatype="html">
Expand All @@ -12679,14 +12679,14 @@ The branches will be removed but the steps will remain in the unit.</source>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">63,67</context>
<context context-type="linenumber">64,68</context>
</context-group>
</trans-unit>
<trans-unit id="5945303094335274412" datatype="html">
<source>Select step</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">20,23</context>
<context context-type="linenumber">20,24</context>
</context-group>
</trans-unit>
<trans-unit id="2586703779914969213" datatype="html">
Expand All @@ -12695,7 +12695,7 @@ The branches will be removed but the steps will remain in the unit.</source>
}}"/></source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">30,33</context>
<context context-type="linenumber">31,34</context>
</context-group>
</trans-unit>
<trans-unit id="1566882762026396179" datatype="html">
Expand All @@ -12704,35 +12704,35 @@ The branches will be removed but the steps will remain in the unit.</source>
}}"/></source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">43,46</context>
<context context-type="linenumber">44,47</context>
</context-group>
</trans-unit>
<trans-unit id="2277347790216751711" datatype="html">
<source>Has rubric/teaching tips</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">54,57</context>
<context context-type="linenumber">55,58</context>
</context-group>
</trans-unit>
<trans-unit id="643328772010674978" datatype="html">
<source>Move step</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">73,77</context>
<context context-type="linenumber">74,78</context>
</context-group>
</trans-unit>
<trans-unit id="4169620043010477030" datatype="html">
<source>Copy step</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">83,87</context>
<context context-type="linenumber">84,88</context>
</context-group>
</trans-unit>
<trans-unit id="7892527662707586368" datatype="html">
<source>Delete step</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/authoringTool/project-authoring-step/project-authoring-step.component.html</context>
<context context-type="linenumber">93,97</context>
<context context-type="linenumber">94,98</context>
</context-group>
</trans-unit>
<trans-unit id="8656136323789683230" datatype="html">
Expand Down