Skip to content

feat(Unit Library): Add info about unit types #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

feat(Unit Library): Add info about unit types #2179

merged 5 commits into from
May 13, 2025

Conversation

@breity
Copy link
Member

@breity breity commented May 13, 2025 •
edited
Loading

Changes

  • Adds an info link next to the Type field in the library filters.
  • Adds information about "Other" units to unit details dialog.
  • Changes text of Preview button in unit details dialog for "Other" units.

Test

  • Check that changes listed above appear.
  • Make sure filters and other library functions work as before.

Closes #2178

@breity breity requested a review from hirokiterashima May 13, 2025 16:48
@breity breity self-assigned this May 13, 2025
hirokiterashima
hirokiterashima approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breity breity merged commit f803d10 into develop May 13, 2025
1 check passed
@breity breity deleted the add-info-about-unit-types branch May 13, 2025 18:47
@hirokiterashima
Copy link
Member

hirokiterashima commented May 13, 2025

🎉 This PR is included in version 5.182.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@breity breity

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(Unit Library): Add info about unit types

3 participants

@breity @hirokiterashima