Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Sep 9, 2025

Changes

  • Conditionally disable decimal labels for y-axis. Previously, we were always disabling decimal labels. This was leading to strange behavior when the data points and max values were decimal values, as reported by Kelly.

Test prep

  • Download unit 44494 and import it locally. Steps 3.7 and 3.8 have the data explorer with decimal values.
  • Enable decimals for y-axis for the graph component.
    • Open JSON authoring for the graph components on steps 3.7 and 3.8 and set allowDecimals to true for yAxis. Note that there are multiple yAxis in this component, and they are all set to false. You’ll need to set it to true for all of them.

Test

  • Preview the steps. Make sure that the y-axis shows the correct labels as you choose different options to graph.

@hirokiterashima hirokiterashima self-assigned this Sep 9, 2025
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Sep 9, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review September 9, 2025 04:22
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The fix works as described. 👍

We should also decide on a way to fix this without having to edit the component JSON. Maybe set allowDecimals to true for all y-axes if "Round values to" is set to anything other than integer or something like that?

@hirokiterashima hirokiterashima merged commit 40d672e into develop Sep 10, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the graph-enable-decimal-y-axis branch September 10, 2025 17:24
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.195.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants