Skip to content

fix(Milestones): Resize milestone report graphs on load #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

fix(Milestones): Resize milestone report graphs on load #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e6386
fix(Milestones): Resize milestone report graphs on load
breity Sep 24, 2025
cadb4bc
Updated messages
github-actions[bot] Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/app/teacher/milestone/milestone-report-graph/milestone-report-graph.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ import { rgbToHex } from '../../../../assets/wise5/common/color/color';
import { trimToLength } from '../../../../assets/wise5/common/string/string';

@Component({
selector: 'milestone-report-graph',
styleUrls: ['./milestone-report-graph.component.scss'],
template: '<highcharts-chart [Highcharts]="Highcharts" [options]="chartConfig"></highcharts-chart>',
standalone: false
selector: 'milestone-report-graph',
styleUrls: ['./milestone-report-graph.component.scss'],
template:
'<highcharts-chart [Highcharts]="Highcharts" [options]="chartConfig" (chartInstance)="onLoad($event)"></highcharts-chart>',
standalone: false
})
export class MilestoneReportGraphComponent implements OnInit {
DEFAULT_COLOR = 'rgb(194, 24, 91)';
Expand Down Expand Up @@ -136,4 +137,10 @@ export class MilestoneReportGraphComponent implements OnInit {
}
return seriesData;
}

protected onLoad(chart: Highcharts.Chart): void {
setTimeout(() => {
chart.reflow();
}, 0);
}
}
2 changes: 1 addition & 1 deletion src/messages.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9178,7 +9178,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
<source>Teams</source>
<context-group purpose="location">
<context context-type="sourcefile">src/app/teacher/milestone/milestone-report-graph/milestone-report-graph.component.ts</context>
<context context-type="linenumber">71</context>
<context context-type="linenumber">72</context>
</context-group>
</trans-unit>
<trans-unit id="819750642673322683" datatype="html">
Expand Down