feat!: Add Redirector #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a URL redirection feature to the library, allowing users to route from deprecated URLs to new URLs, including cross-routing-universe redirections. The implementation adds a new Redirector class that leverages the existing routing engine's pattern matching capabilities.
Key Changes:
- Added
Redirectorclass for reactive URL redirection with support for pattern matching and cross-universe navigation - Refactored routing helper functions into a new
RouteHelperclass to enable code reuse betweenRouterEngineandRedirector - Extended the type system with
RedirectedRouteInfoandBuildHrefOptionsto support redirection functionality - Added utility functions
buildHrefandcalculateMultiHashFragmentfor constructing complex cross-universe redirect URLs
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/types.ts | Added new types for redirection (RedirectedRouteInfo, BuildHrefOptions) and exposed Location.path property |
| src/lib/kernel/RouteHelper.svelte.ts | Extracted route parsing and testing logic from RouterEngine into reusable RouteHelper class |
| src/lib/kernel/Redirector.svelte.ts | New Redirector class implementing reactive URL redirection with pattern matching |
| src/lib/kernel/buildHref.ts | New utility to combine path and hash pieces from different URLs with query parameter merging |
| src/lib/kernel/calculateMultiHashFragment.ts | New utility to calculate multi-hash fragments while preserving/updating existing paths |
| src/lib/kernel/preserveQuery.ts | Added overload to mergeQueryParams for merging two URLSearchParams directly |
| src/lib/kernel/LocationLite.svelte.ts | Added path property implementation (sanitizes Windows file: URLs) |
| src/lib/kernel/RouterEngine.svelte.ts | Refactored to use RouteHelper class, removed duplicate code |
| src/lib/index.ts | Exported new Redirector class |
| README.md | Added documentation for URL redirection feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Not a kernel function, merely an utilitarian one.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75.