Skip to content

Conversation

@webJose
Copy link
Contributor

@webJose webJose commented Sep 3, 2025

Fixes #31

@webJose webJose requested a review from Copilot September 3, 2025 08:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Electron support to the router by handling Windows drive letters in file:// URLs. The key change introduces a sanitized path getter that strips drive letters from Electron file paths, ensuring consistent routing behavior across different environments.

  • Adds a new path getter that sanitizes Windows drive letters from file:// URLs
  • Updates internal routing logic to use the sanitized path instead of raw URL pathname
  • Documents Electron usage requirements and setup instructions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/lib/core/RouterEngine.svelte.ts Adds path getter for Electron drive letter handling and updates routing logic
README.md Documents Electron support and usage instructions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@webJose webJose merged commit 543398a into main Sep 3, 2025
1 check passed
@webJose webJose deleted the JP/Electron branch September 3, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Electron Support with Path Routing

2 participants