Skip to content

Conversation

@webJose
Copy link
Contributor

@webJose webJose commented Sep 5, 2025

Fixes #44.

@webJose webJose requested a review from Copilot September 5, 2025 02:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "when" property to the Fallback component that allows custom control over when fallback content should be displayed. This addresses issue #44 by providing override capability for the default fallback logic which only shows content when no routes match.

Key changes:

  • Added WhenPredicate type for custom fallback conditions
  • Modified Fallback component to support conditional rendering via the when prop
  • Created comprehensive test suite covering all routing universes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib/types.ts Added WhenPredicate type definition for custom fallback conditions
src/lib/index.ts Modified exports to be more selective for Router module
src/lib/Router/Router.svelte Added getRouterContextKey function and improved type imports
src/lib/Fallback/Fallback.svelte Implemented when property with conditional rendering logic
src/lib/Fallback/Fallback.svelte.test.ts Added comprehensive test suite covering all routing scenarios
src/testing/test-utils.ts Added testing utilities for router setup and route manipulation
docs/testing-guide.md Added comprehensive testing documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@webJose webJose merged commit 0a23f30 into main Sep 5, 2025
1 check passed
@webJose webJose deleted the JP/Fallback-When branch September 5, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "when" property to the Fallback component

2 participants