Skip to content

Conversation

@webJose
Copy link
Contributor

@webJose webJose commented Sep 27, 2025

No description provided.

@webJose webJose requested a review from Copilot September 27, 2025 22:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Location.navigate() method to respect disallowed routing modes by adding validation checks before navigation occurs.

  • Adds a call to assertAllowedRoutingMode() in the navigate() method to validate routing permissions
  • Updates test mocks to include a setter for the search property
  • Adds comprehensive test coverage for both query preservation and disallowed routing mode scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/testing/test-utils.ts Adds search property setter to location mock for better test compatibility
src/lib/core/LocationLite.svelte.ts Integrates routing mode validation into the navigate method
src/lib/core/LocationLite.svelte.test.ts Adds extensive test coverage for navigate method behavior and routing restrictions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@webJose webJose merged commit 1472307 into main Sep 27, 2025
1 check passed
@webJose webJose deleted the JP/fix branch September 27, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants