Skip to content

fix: Use full URL when standardizing state #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: Use full URL when standardizing state #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/SkHistoryApi.svelte.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ const hoistedVars = vi.hoisted(() => ({

vi.mock(import("$app/state"), async (importOriginal) => {
return {
...importOriginal,
...await importOriginal(),
page: {
get url() {
return hoistedVars.urlMock();
return hoistedVars.urlMock() ?? new URL("http://localhost/");
},
get state() {
return hoistedVars.stateMock();
}
},
} as Page
}
});
Expand Down
2 changes: 1 addition & 1 deletion src/lib/SkHistoryApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class SkHistoryApi implements HistoryApi {
if (browser && !isConformantState(page.state)) {
// I tried with replaceState() here, throws with error "cannot use before router initializes".
// So, using goto() with replaceState: true. This triggers an update on page.url, though.
goto('', { replaceState: true, state: { path: page.state, hash: {} } });
goto(page.url.toString(), { replaceState: true, state: { path: page.state, hash: {} } });
}
}

Expand Down