Skip to content

Conversation

@webJose
Copy link
Contributor

@webJose webJose commented Nov 13, 2025

No description provided.

@webJose webJose requested a review from Copilot November 13, 2025 22:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the package from @wjfe/n-savant-sk to @svelte-router/kit and updates all references to the core package from @wjfe/n-savant to @svelte-router/core. The changes also include API updates where implicitMode: 'hash' is replaced with defaultHash: true, along with corresponding type changes and test updates.

Key changes:

  • Package name changed from @wjfe/n-savant-sk to @svelte-router/kit with version bump to 1.0.0-beta.0
  • Core package references updated from @wjfe/n-savant to @svelte-router/core, including subpath imports (/core/kernel)
  • API change: implicitMode: 'hash' replaced with defaultHash: true, with additional validation to prevent false values

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/routes/+layout.svelte Updated commented import statement to reference new package name
src/lib/types.ts Updated all package references and module declarations; modified SkInitOptions type to use defaultHash instead of implicitMode
src/lib/init.ts Added validation to prevent defaultHash: false, replaced implicitMode: 'hash' with defaultHash: true
src/lib/init.svelte.test.ts Updated test descriptions and assertions to reflect API changes from implicitMode to defaultHash
src/lib/calculateSkHref.ts Updated package references in code comments and examples
src/lib/SkLocation.ts Updated import statements to reference new package names and subpaths
src/lib/SkLocation.svelte.test.ts Updated test setup calls to use defaultHash: true instead of implicitMode: 'hash'
src/lib/SkHistoryApi.ts Updated import statements to reference new package names
src/lib/SkFallback.svelte Updated import statement to reference new core package name
package.json Updated package name, version, and peer dependency reference
README.md Updated all documentation references to reflect new package names and added additional usage example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webJose webJose merged commit a48fe8d into main Nov 13, 2025
1 check passed
@webJose webJose deleted the JP/rename branch November 13, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants