EndpointRequest customization

[edygar]

Could https://github.com/WP-API/node-wpapi/blob/master/lib/endpoint-factories.js#L41 refer to handlers[ resource ].Ctor instead directly to var EndpointRequest?

I need to inject some code before and after any of the _httpMethod are called but the way it is today, I would need to actually mutate each EndpointRequest instance where I could just inherit from them. Also,invokeAndPromisify been privated locks me of just overriding it.

Can somebody help me? My intention is to have access to the RequestData itself, so I could resolve locally when possible (as for local cache or optimistic updates)

[kadamwhite]

@edygar That sounds like it'd be a good idea, that would be a useful seam to introduce. Can you share some pseudocode of what you'd be hoping for, so I can make sure I understand your idea?

[kadamwhite]

Also, it sounds like what you're looking for is direct access to WPRequest, more than to the Ctors for the individual handlers -- is that an accurate assessment?

[edygar]

Just for context: I'm working on a Redux Middleware which needs to act between the query declaration and the request. In case of data retrieval and if the data is already available, it should resolve the promise right alway. In case of mutations, it should update local data .

Also, it sounds like what you're looking for is direct access to WPRequest, more than to the Ctors for the individual handlers -- is that an accurate assessment?

@kadamwhite, yes, if I could just inject a WPRequest factory, it would solve my problem of access. Here's a very simplified pseudo-code to illustration such intervetion:

_httpGet( callback = _.nthArg(0) ) {
  var cache = this._getCacheIfAvailable();
  if (cache) {
    return Promise.resolve(cache).then(callback);
  }
  return WPRequest._httpGet.call(this, result => {
    this._refreshCache(result);
    return result;
  }).then(callback);
}

_httpPost( callback = _.nthArg(0) ) {
  var pastState = this._getCacheIfAvailable();
  this._refreshCache(this.processedData());
  return WPRequest._httpPost.call(this, callback).catch( e => {
    this._refreshCache(pastState);
    throw e;
  });
};

[kadamwhite]

@edygar Thank you for clarifying, that makes a lot more sense. I'll look into it

[kadamwhite]

Consider whether providing customization of WPRequest can also become a vector for injecting handling for different authentication schemes (note to self)

[kadamwhite]

@edygar I just opened #220 to attempt to provide an official way to modify the HTTP behavior; I would welcome your feedback on that API!