Skip to content

Feat: Remote Deployment and Running #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2016
Merged

Feat: Remote Deployment and Running #204

merged 4 commits into from
Jan 3, 2016

Conversation

@JLLeitschuh
Copy link
Member

@JLLeitschuh JLLeitschuh commented Dec 11, 2015

Adds the ability to deploy and run GRIP on a remote platform.
There is currently no GUI for it at the moment

Deployment Menu
Not saved yet dialog
Simple Deploy
Advanced Deploy
Durring Deploy

JLLeitschuh
JLLeitschuh reviewed Dec 11, 2015
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/util/deployment/HeadlessInstanceManager.java Outdated
Copy link
Member Author

@JLLeitschuh JLLeitschuh Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch from e9b7124 to 1b73fde Compare December 11, 2015 20:36
@codecov-io
Copy link

codecov-io commented Dec 11, 2015

Current coverage is 48.82%

Merging #204 into master will decrease coverage by -4.96% as of 22f370d

@@            master    #204   diff @@
======================================
  Files          105     113     +8
  Stmts         2947    3240   +293
  Branches       335     346    +11
  Methods          0       0       
======================================
- Hit           1585    1582     -3
+ Partial        103      99     -4
- Missed        1259    1559   +300

Review entire Coverage Diff as of 22f370d

Uncovered Suggestions

  1. +0.71% via ...loyerController.java#99...121
  2. +0.65% via ...InstanceManager.java#174...194
  3. +0.43% via ...cketPreviewView.java#38...51
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

ThomasJClark
ThomasJClark reviewed Dec 22, 2015
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/util/deployment/SecureShellDetails.java Outdated
Copy link
Contributor

@ThomasJClark ThomasJClark Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default usernames and passwords is not a good reason to use inheritance. Just pass the variables directly

10/10

@ThomasJClark
Copy link
Contributor

ThomasJClark commented Dec 22, 2015

Formatting 11/10

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch 4 times, most recently from 90dc46f to 4d1ff60 Compare December 28, 2015 18:47
JLLeitschuh
JLLeitschuh reviewed Dec 29, 2015
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/util/deployment/DeployedInstanceManager.java Outdated
Copy link
Member Author

@JLLeitschuh JLLeitschuh Dec 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. See, @ThomasJClark codacity was useful.

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch 2 times, most recently from 2952994 to 7d86397 Compare December 29, 2015 21:51
JLLeitschuh
JLLeitschuh reviewed Dec 30, 2015
View reviewed changes
core/src/main/java/edu/wpi/grip/core/Main.java Outdated
Copy link
Member Author

@JLLeitschuh JLLeitschuh Dec 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"SUCCESS! The project is running in headless mode!"

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch from 7d86397 to e35c708 Compare December 31, 2015 05:21
JLLeitschuh
JLLeitschuh reviewed Jan 2, 2016
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/deployment/FRCDeploymentOptionsController.java Outdated
Copy link
Member Author

@JLLeitschuh JLLeitschuh Jan 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch from e35c708 to 82d9b6c Compare January 2, 2016 05:27
WPIRoboticsProjects-Bot
WPIRoboticsProjects-Bot reviewed Jan 2, 2016
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/util/deployment/DeployedInstanceManager.java Outdated
Copy link

@WPIRoboticsProjects-Bot WPIRoboticsProjects-Bot Jan 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: System.err.println is used

Copy link

@WPIRoboticsProjects-Bot WPIRoboticsProjects-Bot Jan 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: System.err.println is used

WPIRoboticsProjects-Bot
WPIRoboticsProjects-Bot reviewed Jan 2, 2016
View reviewed changes
ui/src/main/java/edu/wpi/grip/ui/deployment/FRCDeploymentOptionsController.java Outdated
Copy link

@WPIRoboticsProjects-Bot WPIRoboticsProjects-Bot Jan 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Avoid using if...else statements without curly braces

Copy link

@WPIRoboticsProjects-Bot WPIRoboticsProjects-Bot Jan 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Avoid using if...else statements without curly braces

@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch from 82d9b6c to e0984d2 Compare January 2, 2016 06:19
@JLLeitschuh
Feat: Remote Deployment and Running
53e156a 
Adds the ability to deploy and run GRIP on a remote platform.
There is currently no GUI for it at the moment
@JLLeitschuh
Adds UI for deploying to remote device
764b534
@JLLeitschuh
Refactors Deployment to use dependency injection
c7b006f
@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch 2 times, most recently from 9e837f1 to 649ed2d Compare January 3, 2016 04:02
@JLLeitschuh JLLeitschuh force-pushed the feat/copyToRemoteDeviceAndLaunch branch from 649ed2d to ba29f88 Compare January 3, 2016 04:03
JLLeitschuh added a commit that referenced this pull request Jan 3, 2016
@JLLeitschuh
Merge pull request #204 from JLLeitschuh/feat/copyToRemoteDeviceAndLa…
617e0fa 
…unch

Feat: Remote Deployment and Running
@JLLeitschuh JLLeitschuh merged commit 617e0fa into WPIRoboticsProjects:master Jan 3, 2016
@ThomasJClark ThomasJClark mentioned this pull request Jan 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready for review type: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JLLeitschuh @codecov-io @ThomasJClark @WPIRoboticsProjects-Bot