Fix various deployment problems #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
JLLeitschuh
force-pushed
the
fix/deploymentProblems
branch
from
d511aa9 to
b4bb0f7
Compare
Contributor
There was a problem hiding this comment.
Not sure if this helps here, but Guice has built in bindings for Logger
Member
Author
There was a problem hiding this comment.
We still have to set it up somewhere.
Also, adding a logger using dependency injection is more of a hassle than it's worth.
JLLeitschuh
force-pushed
the
fix/deploymentProblems
branch
3 times, most recently
from
4eb8321 to
f83baab
Compare
JLLeitschuh
force-pushed
the
fix/deploymentProblems
branch
from
f83baab to
0b7e11f
Compare
- ARM Java does not support aop so we need to change what guice we are using - Deploying can throw null pointers because writing text to the text box was not in the UI thread. - Logging was setup after the guice injector was loaded meaning problems with injecting wouldn't be logged. - The GRIPCore module assumed that the main file would be registered on the event bus to log exceptions but it isn't until after the injector is created. - The thread that manages starting GRIP on a remote device does not actually post a startstopped event if the shell crashes - The logger was printing to System.err which jsch wasn't picking up on. (Further investigation required)
JLLeitschuh
force-pushed
the
fix/deploymentProblems
branch
from
0b7e11f to
78483c7
Compare
ThomasJClark
added a commit
that referenced
this pull request
Jan 5, 2016
Fix various deployment problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not in the UI thread.
injecting wouldn't be logged.
event bus to log exceptions but it isn't until after the injector is created.
post a startstopped event if the shell crashes