fastapi-proxy-lib causes logging duplication

[dvarrazzo]

The libraries calls loggin.debug() here:

fastapi-proxy-lib/src/fastapi_proxy_lib/core/http.py

Lines 276 to 281 in a45086a

	logging.debug(
	"HTTP: client:%s ; url:%s ; head:%s",
	request.client,
	proxy_request.url,
	proxy_request.headers,
	)

As a side effect, this function calls logging.basicConfig() if no handler is set on the root handler:

https://github.com/python/cpython/blob/5e65a1acc0b630397f1d190aed279114e6e99612/Lib/logging/__init__.py#L2204

This result in applications logging entries twice, if they don't use the root handler:

auth-api-c49b5985b-g8z7t api INFO:     test
auth-api-c49b5985b-g8z7t api INFO:authserver.routers.user_group_v2:test

as a workaround I am registering a null handler on the root logger:

logging.getLogger().addHandler(logging.NullHandler())

It's a bad practice for the library to call basicConfig(). Instead of the stupid top-level logging functions you should use your own logger, e.g.

# in core/http.py
import logging
logger = logging.getLogger("fastapi-proxy-lib")

...
logger.debug( 
     "HTTP: client:%s ; url:%s ; head:%s", 
     ...)

[WSH032]

Hi @dvarrazzo, thank you for reporting this. I have wanted to do this for a long time, but I no longer use this library, so I lack the motivation to further develop it.

If you submit a PR, I will merge it.

I prefer using this form:

# In every file that uses `logging.debug`
import logging
logger = logging.getLogger(__name__)
...

[dvarrazzo]

Thank you. I'll see if I can get around making a MR. Knee deep in other issues right now.

logging.getLogger(__name__) would work well too, sure.

Thank you for this library, it was very simple to use :)