Skip to content

feat: Compact Route View #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 23, 2025
Merged

feat: Compact Route View #1131

merged 10 commits into from
Sep 23, 2025

Conversation

@Mygod
Copy link
Collaborator

@Mygod Mygod commented Sep 23, 2025

Routes Display Updates

  • Added a compact/legacy toggle in the routes drawer so users can flip between the new flag-based view and the traditional “show every path” mode (src/features/drawer/Routes.jsx:14-58).
  • Introduced a dedicated route store and data layer to cache routes, group POIs, and drive the compact map overlay (src/features/route/useRouteStore.js:7-187, src/features/route/RouteLayer.jsx:1-155).
  • Reworked route rendering so reversible paths show blue flags at both ends, directional-only paths get an inline arrow, and clicking the polyline opens a popup at the precise click location without nesting Leaflet popups (src/features/route/RouteTile.jsx:24-223, src/features/route/RoutePopup.jsx:134-226, src/assets/css/main.css:79-105).
  • Restored the POI count badge using the original pill styling and offset, tied to the blue flag marker, so stacked routes are clearly indicated (src/features/route/RouteLayer.jsx:15-52, src/assets/css/main.css:95-109).
  • Updated the GraphQL core fragment to bring back start/end fort IDs used for POI grouping (src/services/queries/route.js:5-14) and cleaned up exports after removing the old flag helper (src/features/route/index.js:3-6, deleted src/features/route/routeFlagMarker.js).

Implemented by Codex. Fixes #953. Supersedes #1126.

@Mygod Mygod requested a review from Copilot September 23, 2025 06:31
Copilot AI reviewed Sep 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a compact route view feature that allows users to toggle between a new flag-based route display and the traditional full route visualization mode.

  • Added a route store with caching and POI grouping logic to support the new compact view
  • Implemented compact route rendering with blue flags, directional arrows, and clickable route counts
  • Added a toggle in the routes drawer to switch between compact and legacy route display modes

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/services/queries/route.js Added start_fort_id and end_fort_id fields to GraphQL route fragment
src/pages/map/components/QueryData.jsx Added special handling for routes category to use new RouteLayer component
src/features/route/useRouteStore.js New Zustand store for route caching, POI indexing, and selection state management
src/features/route/index.js Added exports for new RouteLayer and useRouteStore modules
src/features/route/RouteTile.jsx Enhanced route rendering with orientation support, direction arrows, and inline popups
src/features/route/RoutePopup.jsx Added inline mode support for popups displayed outside of markers
src/features/route/RouteLayer.jsx New component implementing compact route view with anchor points and route counting
src/features/pokestop/PokestopTile.jsx Added route store integration for POI click handling
src/features/gym/GymTile.jsx Added route store integration for POI click handling
src/features/drawer/Routes.jsx Added compact view toggle switch in routes drawer
src/assets/css/main.css Added CSS styles for direction arrows and route count badges

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mygod Mygod requested a review from Copilot September 23, 2025 07:13
Copilot AI reviewed Sep 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Mygod
Mygod commented Sep 23, 2025
View reviewed changes
Copy link
Collaborator Author

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks pretty good to me now.

@Mygod
Copy link
Collaborator Author

Mygod commented Sep 23, 2025

image

Irreversible routes are now properly displayed for morons that create these. Codex had a lot of trouble with this.

Old route view:

image

@Mygod Mygod requested a review from Copilot September 23, 2025 17:27
Copilot AI reviewed Sep 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mygod Mygod requested a review from Copilot September 23, 2025 17:51
Copilot AI reviewed Sep 23, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mygod Mygod merged commit 795976e into WatWowMap:develop Sep 23, 2025
2 checks passed
@Mygod Mygod deleted the route-codex branch September 23, 2025 18:06
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
@semantic-release-bot
chore(release): v1.39.0-develop.4 [skip ci]
7a832cd 
# [1.39.0-develop.4](v1.39.0-develop.3...v1.39.0-develop.4) (2025-09-23)

### Features

* Compact Route View ([#1131](#1131)) ([795976e](795976e))
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

🎉 This PR is included in version 1.39.0-develop.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 24, 2025
@semantic-release-bot
chore(release): v1.39.0 [skip ci]
276ba48 
# [1.39.0](v1.38.0...v1.39.0) (2025-09-24)

### Bug Fixes

* ditto filtering ([2fe3af3](2fe3af3))
* localization ([f02e8cd](f02e8cd))
* refinements to interaction between gyms/stops and routes ([8c0ba37](8c0ba37))
* relative timer not updating ([72b0a8c](72b0a8c))
* skip updated filtering if shortcode is present ([b0cfe13](b0cfe13))
* translation ([5a02a6b](5a02a6b))

### Features

* Compact Route View ([#1131](#1131)) ([795976e](795976e))
* display actual battle bonus via stationed pokemon ([ba51f47](ba51f47))
* estimated shiny probability for pokemon ([#1133](#1133)) ([d44a3df](d44a3df))
* route share code ([4ac76d0](4ac76d0))
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

🎉 This PR is included in version 1.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

released on @develop released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mygod