feat: persistent popups #1135
feat: persistent popups #1135
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements persistent popups functionality that allows popups to remain visible even when objects are dragged out of view. The changes enable manual tracking of popups by storing their ID and category in application state, ensuring they can be retrieved and displayed even outside current viewport bounds.
- Adds manual popup tracking system with hooks and utilities for normalizing categories
- Modifies clustering logic to always include manually tracked items
- Updates backend models to support manual ID filtering alongside spatial queries
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/normalizeCategory.js | New utility to normalize category names for consistent data/UI lookups |
| src/hooks/useManualPopupTracker.js | New hook to track manual popup state in memory store |
| src/pages/map/components/QueryData.jsx | Integrates manual ID filtering into data queries |
| src/pages/map/components/Clustering.jsx | Ensures manually tracked items bypass clustering |
| Multiple tile components | Adds popup tracking handlers to various map features |
| server/src/utils/manualFilter.js | New server utility for manual ID filtering with spatial bounds |
| Multiple server models | Updates database queries to support manual ID filtering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# [1.40.0-develop.1](v1.39.0...v1.40.0-develop.1) (2025-09-25) ### Features * persistent popups ([5cd5be0](5cd5be0)), closes [#1135](#1135)
|
🎉 This PR is included in version 1.40.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Popups will still be there even if dragged out of view, which is pog! This also solves the usability issue of some popups being too tall. :)
Fixes #1132. Requires UnownHash/Golbat@bdf3d4b for Pokemon.
P.S. Context use so high. 😓 I also had to use my brain to figure out how to properly prompt Codex which I didn't like.
