Skip to content

Conversation

@TurtIeSocks
Copy link
Collaborator

  • Filter quests by their conditions now if a reward has multiple conditions
  • Rework available, returns an object instead now for future expandability
  • questConditions gql api update
  • version bump
  • Make better use of promise.all in getAvailable pokestops method to reduce query time

Screen Shot 2022-06-09 at 1 04 58 AM

s

- Filter quests by their conditions now if a reward has multiple conditions
- Rework available, returns an object instead now for future expandability
- questConditions gql api update
- version bump
- Make better use of promise.all in getAvailable pokestops method to reduce query times
Copy link
Collaborator

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

life changing wish could approve more

@pjorritsma
Copy link
Contributor

My community would love this feature, alot of requests about it.

@ReuschelCGN
Copy link
Contributor

works nice - translation for "Earn 3 Candies exploring with your buddy" is missing ....

@TurtIeSocks
Copy link
Collaborator Author

Did you regenerate locales? This commit fixes it 005e850

@kamieniarz
Copy link
Contributor

kamieniarz commented Jun 9, 2022

Awesome PR! Thanks! Just one thing - that Tt icon could be changed to gear wheel or how it's called. I mean standard settings icon. And obviously an option to select more than one quest type but I accume that already in plans ;)

- Consistent icons & dialog text
- Sort the conditions
- Remove now unnecessary locale fixing
- Better merging for multi db setups
@TurtIeSocks TurtIeSocks merged commit bb130d3 into develop Jun 11, 2022
@TurtIeSocks TurtIeSocks deleted the quest-condition-filtering branch June 1, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants