Available Slots Compatibility #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TurtIeSocks
commented
Jun 19, 2022
TurtIeSocks
commented
- Updates SQL query to use a dynamic column name based on a startup check
- Maintains backwards compatibility for older RDM clients that are still using availble_slots
- Updates SQL query to use a dynamic column name based on a startup check - Maintains backwards compatibility for older RDM clients that are still using availble_slots
Contributor
|
This misspelling is fixed in rdm master since december.... I kept old column for compatibility. Why not simple use it and remove the magic to keep it clean? Someone who runs RDM master from december is save. Someone who's not running this state can also run RM from an older state 🤣 |
Collaborator
Author
|
More backwards compatibility = less dumb questions to answer later 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.